Project

General

Profile

Bug #790

sqlbox automake failing version checking

Added by Michael Fayez about 1 year ago. Updated about 1 year ago.

Status:
New
Priority:
High
Assignee:
-
Category:
General
Target version:
-
Start date:
08/29/2018
Due date:
% Done:

0%

Estimated time:
Affected version:

Description

using automake 1.15 and 1.16.1

hitting "you need automake version 1.5 or later"

here is a patch that solved this issue and POSIX complaint:

--- bootstrap
+++ bootstrap
@@ -4,26 +4,28 @@

 # Check for automake
 amvers="no" 
-if automake-1.11 --version >/dev/null 2>&1; then
-  amvers="-1.11" 
-elif automake-1.10 --version >/dev/null 2>&1; then
-  amvers="-1.10" 
-elif automake-1.9 --version >/dev/null 2>&1; then
-  amvers="-1.9" 
-elif automake-1.8 --version >/dev/null 2>&1; then
-  amvers="-1.8" 
-elif automake-1.7 --version >/dev/null 2>&1; then
-  amvers="-1.7" 
-elif automake-1.6 --version >/dev/null 2>&1; then
-  amvers="-1.6" 
-elif automake-1.5 --version >/dev/null 2>&1; then
-  amvers="-1.5" 
-elif automake --version > /dev/null 2>&1; then
+#if automake-1.11 --version >/dev/null 2>&1; then
+#  amvers="-1.11" 
+#elif automake-1.10 --version >/dev/null 2>&1; then
+#  amvers="-1.10" 
+#elif automake-1.9 --version >/dev/null 2>&1; then
+#  amvers="-1.9" 
+#elif automake-1.8 --version >/dev/null 2>&1; then
+#  amvers="-1.8" 
+#elif automake-1.7 --version >/dev/null 2>&1; then
+#  amvers="-1.7" 
+#elif automake-1.6 --version >/dev/null 2>&1; then
+#  amvers="-1.6" 
+#elif automake-1.5 --version >/dev/null 2>&1; then
+#  amvers="-1.5" 
+#elif
+if automake --version > /dev/null 2>&1; then
   amvers="`automake --version | sed -e '1s/[^0-9]*//' -e q`" 
-  if expr "$amvers" "<" "1.5" > /dev/null 2>&1; then
-    amvers="no" 
-  else
+#  if expr "$amvers" "<" "1.5" > /dev/null 2>&1; then
+  if expr match ${amvers} '\([1].\([^0-4]\|[1-9][0-9]\).*\|2.*\)' ; then
     amvers="" 
+  else
+    amvers="no" 
   fi
 fi

History

#1 Updated by Michael Fayez about 1 year ago

#ref
here is the regex match-set

https://regex101.com/r/kayHRi/1

#2 Updated by Michael Fayez about 1 year ago

this is a simplified patch... hope if it could be merged

and we may expand the regex not to touch it again by adding 2-9...

i.e

\([1].\([^0-4]\|[1-9][0-9]\).*\|[2-9].*\)
--- bootstrap
+++ bootstrap
@@ -4,26 +4,12 @@

 # Check for automake
 amvers="no" 
-if automake-1.11 --version >/dev/null 2>&1; then
-  amvers="-1.11" 
-elif automake-1.10 --version >/dev/null 2>&1; then
-  amvers="-1.10" 
-elif automake-1.9 --version >/dev/null 2>&1; then
-  amvers="-1.9" 
-elif automake-1.8 --version >/dev/null 2>&1; then
-  amvers="-1.8" 
-elif automake-1.7 --version >/dev/null 2>&1; then
-  amvers="-1.7" 
-elif automake-1.6 --version >/dev/null 2>&1; then
-  amvers="-1.6" 
-elif automake-1.5 --version >/dev/null 2>&1; then
-  amvers="-1.5" 
-elif automake --version > /dev/null 2>&1; then
+if automake --version > /dev/null 2>&1; then
   amvers="`automake --version | sed -e '1s/[^0-9]*//' -e q`" 
-  if expr "$amvers" "<" "1.5" > /dev/null 2>&1; then
-    amvers="no" 
-  else
+  if expr match ${amvers} '\([1].\([^0-4]\|[1-9][0-9]\).*\|2.*\)' ; then
     amvers="" 
+  else
+    amvers="no" 
   fi
 fi

Also available in: Atom PDF